Skip to content

Make table header tooltips keyboard accessible#632

Merged
novykh merged 1 commit into
masterfrom
agent/fix-table-header-accessibility
Jul 14, 2026
Merged

Make table header tooltips keyboard accessible#632
novykh merged 1 commit into
masterfrom
agent/fix-table-header-accessibility

Conversation

@ktsaou

@ktsaou ktsaou commented Jul 13, 2026

Copy link
Copy Markdown
Member

Summary

  • make shared table-header overflow tooltips reachable by keyboard
  • allow sortable headers to sort with Enter and Space and expose the current sort state
  • keep drag and resize interactions isolated from sorting
  • preserve explicit labelProps accessibility and keyboard behavior

Behavior

  • header labels become focusable when they can expose a tooltip or sort
  • tooltips still open only when the rendered header is truncated
  • custom aria-label, role, tabIndex, and onKeyDown behavior remain supported
  • custom handlers can prevent the built-in keyboard sort action
  • non-sortable React headers without tooltip text do not become inert tab stops
  • drag handles use a dedicated data attribute instead of a styling class for interaction detection
  • no per-header observer or tooltip controller is added

Scope

This is a focused accessibility and compatibility follow-up to #631. It applies to every application table using the shared Table header and does not alter row rendering, virtualization, sizing, or data behavior.

Related cloud cleanup follow-up: netdata/cloud-frontend#5611. The PRs are independently mergeable.

Validation

  • 92/92 suites passed
  • 464/464 tests passed
  • 9/9 snapshots passed
  • UMD, CJS, and ES6 builds passed
  • integrated cloud development build passed

@ktsaou ktsaou marked this pull request as ready for review July 13, 2026 16:44
@novykh novykh merged commit 7bb846d into master Jul 14, 2026
3 checks passed
@novykh novykh deleted the agent/fix-table-header-accessibility branch July 14, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants